Modifications to support additional offload builds #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mewall
requested review from
cnegre,
jeanlucf22,
jmohdyusof,
nicolasbock,
suemni and
tokshgithub
as code owners
suemni
approved these changes
Jul 13, 2021
nicolasbock
approved these changes
Jul 13, 2021
jeanlucf22
reviewed
Jul 13, 2021
scripts/setenv_spock_offload.sh
Outdated
| #!/bin/bash | ||
|
|
||
| module load craype-accel-amd-gfx908 | ||
| #module unload cray-mvapich2 cray-libsci |
There was a problem hiding this comment.
why keep all theses commented out modules?
There was a problem hiding this comment.
Comments have been removed.
jeanlucf22
approved these changes
Jul 13, 2021
Revised the code to build on ORNL spock and Cray/HPE tulip: o Use the same offload code path for CRAY_SDK macro as for INTEL_SDK macro o Modify bml_add_norm_ellpack() and bml_add_identity_ellpack() to follow similar syntax as in bml_add_ellpack() - Note: Tests needed for bml_add_norm_ellpack() and bml_add_identity_ellpack() o Create a typed bml_deallocate_ellpack() (see issue #524) o Add scripts for building on spock - scripts/setenv_spock_offload.sh - scripts/build_spock_offload_cce.sh o Add scripts for building on tulip - scripts/setenv_tulip_offload.sh - scripts/build_tulip_offload_cce.sh
cnegre
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised the code to build on ORNL spock and Cray/HPE tulip:
o Use the same offload code path for CRAY_SDK macro as for INTEL_SDK macro
o Modify bml_add_norm_ellpack() and bml_add_identity_ellpack()
to follow similar syntax as in bml_add_ellpack()
o Create a typed bml_deallocate_ellpack() (see issue Create a typed deallocator in bml_allocate_ellpack.c #524)
o Add scripts for building on spock
o Add scripts for building on tulip